Adds the Outfits Magazines Quickinfo by artifax and sganon from U4H8
Known Bugs:
- mag_compatible_weapons not showing
- Green describtion on exosuits
Changelog:
Patch 5 (16.04.20):
- Fixed green describition on exosuits
- (Hopefully) fixed / changed rus translation
Patch 4 Hotfix 1 (04.04.20):
- Fixed wrong encoding in rus text
Patch 4 (03.04.20):
- Added russian translation (UNTESTED)
- Added text files to rename "small/medium/large magazines" (configs/text/)
- Included some general crashfixes in magazines script itself by Vintar
Patch 3 (02.04.20):
- Fixed "mag_compatible_weapons" override
Patch 2 (01.04.20):
- Removed dependency on "ui.item.script" .
Delete old "ui.item.script" from mod if updating from previous version.
- Fixed the crashes
Patch 1 (01.04.20 ):
- Fixed overriding Magazine Info
- Fixed overriding Outfit Info (Faction, Headgear, Sprint)
Wow vary cool I been waiting for this no more guessing how many mags u can have with suits 🙀
Yea, its a great QoL feature. Found this little gem in Muhs Mags for U4H8
This is actually nice. But unfortunately this overrides the linked text config that includes all informations about magazines, like the supported calibers, weapon types, and all the related infoirmation about the selected mag.
Example: Usually when you see the details on a magazine (hoover the mouse over it), it will display for example something like:
Standar AKS74 Magazine caliber 5.45x39. Mag_Compatible_weapons: AK-47, ....
mag_ammo_loaded_count: 30 / 30
15x 5.45x39 mm rounds FMJ
15x 5.45x39 mm rounds AP
So somehow only the new two added functions override those other functions (like mag_ammo_loaded_count) and the st_items_magazines text config.
Thank you, fixed
It crashes my game when I move my cursor over the outfit.
Which outfit?
Every outfit it seems. Log says this:
FATAL ERROR
[error]Expression : <no expression>
[error]Function : CScriptEngine::lua_error
[error]File : ..\xrServerEntities\script_engine.cpp
[error]Line : 191
[error]Description : fatal error
[error]Arguments : LUA error: ...ps/common/anomaly/bin/..\gamedata\scripts\ui_item.script:667: attempt to index global 'wuut_mags' (a nil value)
stack trace:
You have my discord. Contact me if you need any further stuff.
Thank you, fixed
You are a god damned legend.
Thanks, but it was mainly just copy & paste ^^
Hi!
MY ENGLISH IS "MACDONALDS", sorry for that
Can you move the magazine size "Small Magazines" into a separate file, for example, into the "gamedata\configs\text" folder ??
(Translate into another language)
Hey,
im not sure i understand what you mean?
Do you want to change the text "Small Magazines" into something else?
yes, but I wanted to do it correctly without going into your file and without changing anything in it
P S
if there is no such possibility, then God be with him.
По-английски реально не понятно, что ты хочешь от аддона, напиши, я переведу на инглиш
да в принципе, это было не критично, просто не хотел надписи внутри скрипта изменять, хотел "по человечески" сделать, чтоб выделенный файл с локализацией был. Просто была просьба)
Added the possibility to rename "small/medium/large magazine" in Update 4 for Eng and Ru language (/configs/text/.../)
NICE! So this is it? Just by adding " or 0" to the end of the related functions fixes the engine-related crashes that occured when that local returned nil? Ok, it's actually the same thing happeneing, as when adding a nil check that wwould end the function aand return -1. So he has removed the temporary crash fix (nil check) and just added nil to be a valid condition, hich prevents LUA from crying out.
But why removing those debug outputs?
However, that's great!!
EDIT: Hey, your text config file is in the wrong frolder. In your archive the folder is called "RU", but it should be called "RUS".
Thanks, changed it to "rus" - Cant test the translation, my game crashes without a log when i change the language.
Guess im lucky, never had any crashes with magazines. And im not that familiar with scripts to know exactly why this fix works. Vintar sent me his wuut_mags.script and said i can include it if i want
I've included it in my own patches that use this script and gave credits to Vintar, you and this addon.
Hey, would you mind asking your friend if he's able to fix the UI update behavior in mags? When you recharge a mag, the UI won't update properly and showing improper loading stats (condition bar) below them, until you either reopen the inventory or do something with the mag (like put into outfit slot, etc). But for a reason the UI update works properly in the stacks display (where you can see stackd items seperately).
My LUA knowledge is way too limited for this.
Cant reproduce the error, condition bars are updating immediately here, only loaded rounds/capacity on the mags tooltip is a bit behind (takes a few seconds)
YOu sure we're talking about the same thing? When loading rounds into a mag, the bar below that mag, the bar below it often stops updating. Sometimes though it works better, but most of the times it's stuck behind and will update either after a few seconds when the mag is fully loaded, or when closing and reopening the inventory, or do something else that forces to update. However, this happens only in the main inventory screen! So try it with loading a mag from which you've got only one in your inventory.
This issue is widely known and nothing I've tried helped to resolve it. I'm wondering how it can work properly for you :)
Imgur.com
you mean this?
перевод русский авпарпншнгшнгшн7шн
Please correct the Russian translation, some Cyrillic characters are written on the suit.
Thanks, fixed
good work. i've suffered from some errors related to magazines. for instance:
FATAL ERROR
[error]Expression : <no expression>
[error]Function : CScriptEngine::lua_error
[error]File : ..\xrServerEntities\script_engine.cpp
[error]Line : 191
[error]Description : fatal error
[error]Arguments : LUA error: ...ps/common/anomaly/bin/..\gamedata\scripts\ui_item.script:667: attempt to index global 'wuut_mags' (a nil value)
like that. thanks for arrangement to solve these errors.
You may want to use these variants of russian translate:
Малые магазины
Средние магазины
Большие магазины
or
Магазины малой емкости
Магазины средней емкости
Магазины большой емкости
Thank you very much, added!
Good to see this coming back!
It crashes my game when i move cursor to leather jacket while im playing
Cant reproduce the error, doesnt crash here. Log?
Hello, I deleted my previous comment because it was inaccurate. Hopefully this new comment paints a clearer picture.
Hovering over any NBC armor causes a crash. I believe this is because in Vanilla Anomaly's o_nbc.ltx all the 'kind' values have semicolons before them, so they read ";kind = o_light" instead of "kind = o_light". I originally thought o_nbc.ltx was altered by another mod, but I found this semicolon stuff in Anomaly's db files as well. This semicolon before 'kind' is also causing problems with other addons, such as Sorting Plus not recognizing NBC armors as outfits.
I'm not sure what purpose the semicolon serves but removing all semicolons before 'kind' from o_nbc.ltx seems to fix the crashing problem. Removing your script without editing o_nbc.ltx also prevents crashing. Is there a way you can edit your script so that we don't have to change vanilla files?
Doesnt crash for me, vanilla and modded. What does the log say?
Strangely enough I reinstalled all my mods recently and I can no longer reproduce the error. Not sure what happened with my last build to get such an error but things are resolved now. So that must mean your script is fine. Sorry for my confusion and thanks for your patience.
Hello! Thanks for the mod, it's really helpful.
But there is a couple of bugs in it.
First problem associated with rus translation, in magazines size lines wrote: "ма?ленький емкость магазина, сре?днего емкость магазина".
It should be something like: "магазины малой ёмкости, магазины средней ёмкости, магазины большой ёмкости"
or "малые магазины, средние магазины, большие магазины" etc.
The second variant is more suitable I guess.
Also there is a couple of question marks in this phrases.
It would be really cool if you could fix this few flaws.
Anyway this mod is good, thank you for it again and good luck! :)
Edit: For some reason every exosuit's (not exoskeleton's) description is written with green font, it's not only in rus version but also in eng.
Thanks for your reply. I cant speak russian and asked a few people how to translate it properly and got 10 different translations, guess the easiest way is to change it yourselves in text/rus/mag_outfit_info_text.xml ^^
I dont know whats causing the green font, works fine on my end (vanilla and modded)
Might be something that also changes ui_item. Ive only tested it with "Cost in Tooltip"
Thanks for quick reply!
It's strange, I've just fresh installed Anomaly and put there only "Magazines 1.5.1." and this mod, this issue is still occuring.
Description on every exosuit is still green, don't know why is it happening on fresh install.
It looks like the description color is bound to max amount of large magazines number color.
I've tried to change it to purple color in mag_outfit_info.script and it worked, max number of large magazines was purple and description too, but I don't know why gray color isn't working.
When I try to change it my game just crashes, only purple works.
Sorry, I'm just super noob in coding, don't know actually nothing, but it looks like the problem is in "mag_outfit_info.script" file.
I dont know why it didnt affect all outfits, but should be fixed now.
Also added your rus translation.
Thank you!
Thank you very much, it is fixed now!
when using anomaly magazines with out this mod if i hover mouse over a magazine it tells me info of
" what type of ammo "
"how much of each type of ammo in each mag "
this mod brakes that it does not tell me what type of ammo and how much is in the mag when hovering over it .
im using anomaly magzines latest
wut mags world models
this mod
Do you use the latest version? That bug occured in an earlier one
i will try the latest version with wut mags aswell brb !
update * using
anomaly magazines
wut mags world models
this mod
evrything works ok , world models work , magazines work , outfit info mags works , and hovering over a mag with mouse now tells u how much and what type of ammo
I get instant crash when trying to look for Merc NBC, For any others Armours or others NBC'S i don't get any CTD. Here is log:
FATAL ERROR
[error]Expression : S && strlen(S)
[error]Function : CInifile::r_section
[error]File : Xr_ini.cpp
[error]Line : 523
[error]Description : assertion failed
stack trace:
Minotaur21 had the same bug (a few comments above yours)
A quick fix, instead of editing the config for the outfit itself, is to add the mag limits to the loadout by adding following lines to "wuut_loadout.ltx"
--NBC
[wlc_nbc_merc_outfit]
mag_limit_small = 4
mag_limit_medium = 2
mag_limit_large = 1
Thank you bro
don't know if is this mod but I got a ctd twice while hovering a duty outfit,
Expression : <no expression>
Function : CScriptEngine::lua_error
File : ..\xrServerEntities\script_engine.cpp
Line : 191
Description : fatal error
Arguments : LUA error: .../stalker anomaly\gamedata\scripts\mag_outfit_info.script:26: attempt to call field 'GetOutfitLoadout' (a nil value)
stack trace:
Something has overwritten wuut_mags.script from the modarchive. Make sure this mod is loaded last
i have similar problem, but GetCurrentLoadout method is called, nothing is overwriting it, mod manager doesn't show me anything is overwriting THIS addon.