Comments - SkippieDipie

I have created a merge request on your GitLab that fixes the issue. Take a look when you can.

The game crashes when trying to upgrade the backpack with workshop.

Mods:
- MCM
- FDDA
- Ultimate Backpack

For full log check your GitLab.

FATAL ERROR

[error]Expression : <no expression>
[error]Function : CScriptEngine::lua_pcall_failed
[error]File : ..\xrServerEntities\script_engine.cpp
[error]Line : 204
[error]Description : fatal error
[error]Arguments : LUA error: e:/locallibrary/stalker anomaly\gamedata\scripts\_g.script:779: attempt to perform arithmetic on local 'num' (a nil value)

stack trace:

Hello, I've got a question.

Is there any particular reason you scripted this addon the way ypu did? Isn't there a better way to check if the weapon is magazine fed that wouldn't require you to create millions of identical magazines?

The way you did it is to first get MagSection based on WeaponSection and if it exists then the weapon is magazine fed. Wouldn't it be better to just create a list that contains all magazine fed weapons and a magazine section coresponding to said weapon. This list could look like this:
magazineFed = {{wpn_m16, mag_stanag}, {wpn_m4, mag_stanag}, {wpn_ak74, mag_ak545}, {wpn_akm, mag_ak762}...}

The magazine entries could themselves be lists to account for magazines of the same family with varied ammo count (for example, ak74 and rpk74 mags are in the same AK 5.45 family, but have different ammo counts).

This list could also contain alternative magazine entries to account for caliber changing modifications. Example:
magazineFed = {{wpn_m16, mag_stanag, mag_stanag_mod}, ...}

This way you wouldn't need to create a new magazine for each weapon that uses the same mag as another weapon.

I hope you will take my suggestions into consideration. Good luck with your mod.

P.S. There are some weapons that should use STANAG magazines but for some reason cannot do that. For example, LR300, HK416 and FN2000 should use the same exact magazine as M16 or M4, but they for some reason cannot do that.

Nice mod, but there are some issues. For example, when you use AK74 PMC with some scopes it doesn't have a laser on, when it obviously should.
Laser works only with these scopes: 1P76, EKP8, Kobra, Meprolight M21, PSO2.
I understand that it might take time to go through all OGF files, but is there any chance that we are going to get this issue fixed?