[PHP] Checking Email Address Thread

if (!ereg('^[-!#$%&\'*+\\./0-9=?A-Z^_`a-z{|}~]+'.'@'.'[-!#$%&\'*+\\/0-9=?A-Z^_`a-z{|}~]+\.'.'[-!#$%&\'*+\\./0-9=?A-Z^_`a-z{|}~]+$', $email))

Thats the code to check to see if its a valid email address, someone I need to integrate it into the code below, which is no easy task HELP!

<?

if ($username  == "" || $password == "" || $email == "" || $password != $password2)

{echo "Error - You missed something out, press back and try again";}

else

{$exists = false;
$usercheck = mysql_query("SELECT username,email FROM unz_users WHERE username = '$username'");
while($check = mysql_fetch_object($usercheck))

if($username == $check->username || $email == $check->email)
$exists = true;

if($exists == true)
{echo "Error - Username or Email address already exists";}

else

{mysql_query("INSERT INTO `unz_users` ( `uid` , `username` , `password`, `email`, `status`, `regdate`, `ip`, `host`) VALUES ('', '$username', '$password',  '$email', 'member', '$regdate', '$ip', '$host')");
echo &quot;$username</br>$password</br>$regdate</br>$email</br>$ip</br>$host </br>User added&quot;;}}

?&gt;

Simple as this:

<?

if ($username  == "" || $password == "" || $email == "" || $password != $password2)

{echo "Error - You missed something out, press back and try again";}

else

{$exists = false;
$usercheck = mysql_query("SELECT username,email FROM unz_users WHERE username = '$username'");
while($check = mysql_fetch_object($usercheck))

if($username == $check->username || $email == $check->email)
$exists = true;

if($exists == true)
{echo "Error - Username or Email address already exists";}
else if(!ereg('^[-!#$%&'*+\./0-9=?A-Z^_`a-z{|}~]+'.'@'.'[-!#$%&'*+\/0-9=?A-Z^_`a-z{|}~]+.'.'[-!#$%&'*+\./0-9=?A-Z^_`a-z{|}~]+$', $email))
{echo "Error - Please enter a valid email address i.e. me@mydomain.com";}
else

{mysql_query("INSERT INTO `unz_users` ( `uid` , `username` , `password`, `email`, `status`, `regdate`, `ip`, `host`) VALUES ('', '$username', '$password',  '$email', 'member', '$regdate', '$ip', '$host')");
echo &quot;$username</br>$password</br>$regdate</br>$email</br>$ip</br>$host </br>User added&quot;;}}

?&gt;

Just need that one else if statement in there thats all

Parse error: parse error, unexpected '.' in /home/virtual/site101/fst/var/www/v2/pages/signup/signing_up.php on line 18

INtense! can code samples have line numbers please?

you need to comment out any ' which is not part of a '.' arrangement, I think.

Noticed, got it fixed, will posted updated code when I get back from work

You realize that your "Username or Email already exists" message is flawed, right? You're not selecting on email = '$email', so the only time the "or Email" would apply is when the username is a duplicate, which is already tested. If you really want to make sure that the same email doesn't get used more than once, check username and email with separate queries.

Also, I have to admit that I dislike your style. Indenting bracketed code makes it much, much easier to read. Perhaps you're trying for obfuscation?

If you'd have read my above post you'd realise thats old code.

<?

if (!$username || !$password || !$email || $password!=$password2)

{echo "Error - You missed something out, press back and try again";}

else

{$exists = false;
$usercheck = mysql_query("SELECT username,email FROM unz_users WHERE username = '$username'");
while($check = mysql_fetch_object($usercheck))

if($username == $check->username || $email == $check->email)
$exists = true;

if($exists == true)
{echo "Error - Username or Email address already exists";}
else if(!eregi("^([a-z0-9]+)([._-]([a-z0-9]+))*[@]([a-z0-9]+)([._-]([a-z0-9]+))*[.]([a-z0-9]){2}([a-z0-9])?$", $email))
{echo "Error - Please enter a valid email address i.e. me@mydomain.com";}
else

{mysql_query("INSERT INTO `unz_users` ( `uid` , `username` , `password`, `email`, `status`, `regdate`, `ip`, `host`) VALUES ('', '$username', '$password',  '$email', 'member', '$regdate', '$ip', '$host')");
echo "Success - You are now a registered member of Wuggawoo.co.uk.";
setcookie ("username", "$username", time()+60*60*24*30,'/','.wuggawoo.co.uk', 0);
setcookie ("password", "$password", time()+60*60*24*30,'/','.wuggawoo.co.uk', 0);}}

?>

Also my bracketing is fine, its my style and to me it makes more sense.

I did read your previous post. Perhaps I didn't explain what I meant very well.

If you want to make sure that neither the username nor the email has been used before, do something like this:

<?

if ( !$username || !$password || !$email || ($password != $password2) )
{
echo "Error - You left something out, press back and try again";
}
else if ( !eregi("^([a-z0-9]+)([._-]([a-z0-9]+))*[@]([a-z0-9]+)([._-]([a-z0-9]+))*[.]([a-z0-9]){2}([a-z0-9])?$", $email) )
{
echo "Error - Please enter a valid email address i.e. me@mydomain.com";
}
else if ( mysql_fetch_row(mysql_query( "select username from unz_users where username = '$username'" )) )
{
echo "Error - Username already exists";
}
else if ( mysql_fetch_row(mysql_query( "select email from unz_users where email = '$email'" )) )
{
echo "Error - Email already exists";
}
else if ( mysql_query("insert into unz_users (uid, username, password, email, status, regdate, ip, host) values ('', '$username', '$password',  '$email', 'member', '$regdate', '$ip', '$host')") )
{
echo "Success - You are now a registered member of wuggawoo.co.uk";
setcookie( "username", "$username", time()+60*60*24*30, '/', '.wuggawoo.co.uk', 0 );
setcookie( "password", "$password", time()+60*60*24*30, '/', '.wuggawoo.co.uk', 0 );
}
else
{
echo "Error - There was a database error when attempting to save your information.  Please try again.";
}

?>

As for your style, I merely said that I dislike it. It's my preference to indent.

[edit]
Well, the code tags don't handle indented code very well, so perhaps it's not really your style that I'm seeing.
[/edit]

- Edited By scope.creep On Fri 30th, May 2003 @ 4:26:03pm

[edit]
I'm not sure about those '$username', etc., things in the SQL. I'd have to test them out to be sure. I'd probably use the extra keystrokes to make it '".$username."', etc.
[/edit]

- Edited By scope.creep On Fri 30th, May 2003 @ 5:21:54pm

My defence for my identing is because I get thje same responce wherever I post it

Your code doesnt work aswell, Error - You left something out, press back and try again no matter what.

*shrug* I don't see how, since I cut/pasted your code, then added () for clarity.

[edit]
Why don't you echo those variables to see what they contain?
[/edit]

- Edited By scope.creep On Fri 30th, May 2003 @ 5:33:01pm

Bizarely everythings being sent to the page correctly and I even posted my if statement at the very top to see if it would work and it still wont, really odd

Ok put my old version back and Im getting the same error so IM assuming its server side at the moment and will retry tomorow.

- Edited By azz0r On Fri 30th, May 2003 @ 11:43:19pm

Ok the problem was me being logged in, hence username and password were already set, put a check on the signup page so its fixed now

Right, now all I have todo is
Username is minimum of 8 characters and contains no obscure characters
Password is minimum of 5 characters and contains no obscure characters
Error message saying that the passwords arent the same
Confirmation email sent to user...eek!

simple:

eregi can sort obscure characters.
If ($password != $password2) sorts the password checking
mail (); is very simple, check in your book of words.

Wrong password check (meant length)

<?

if (!$username || !$password || !$email || $password!=$password2)
{echo "Error - You missed something out, press back and try again";}



else if (!eregi("^([a-z0-9]+)([._-]([a-z0-9]+))*[@]([a-z0-9]+)([._-]([a-z0-9]+))*[.]([a-z0-9]){2}([a-z0-9])?$", $email))
{echo "Error - Please enter a valid email address i.e. me@mydomain.com";}



else if (mysql_fetch_row(mysql_query("SELECT username FROM unz_users WHERE username = '$username'" )))
{echo "Error - Username already exists";}



else if (mysql_fetch_row(mysql_query("SELECT email FROM unz_users WHERE email = '$email'")))
{echo "Error - Email already exists";}



else if ((strlen($username < 6)))
{echo "Error - Username must be 6+ characters long";}



else if(!ereg("^[[:alpha:]]{4,6}$", $username))
{echo "Error - Weird characters in username; are you trying to harm me?";}



else if (mysql_query("INSERT into unz_users (uid, username, password, email, status, regdate, ip, host) VALUE ('', '$username', '$password',  '$email', 'member', '$regdate', '$ip', '$host')"))
{echo "Success - You are now a registered member of wuggawoo.co.uk";
setcookie("username", "$username", time()+60*60*24*30, '/', '.wuggawoo.co.uk', 0);
setcookie("password", "$password", time()+60*60*24*30, '/', '.wuggawoo.co.uk', 0);}


{echo "Error - There was a database error when attempting to save your information.  Please try again.";}

?> 

I thought that might work, guess not

azz0r wrote:

else if ((strlen($username < 6)))
{echo "Error - Username must be 6+ characters long";}

That's the problem. Try this:

else if ( strlen($username) < 6 )
{
echo "Error - Username must be 6+ characters long";
}

OR

else if ( (strlen($username) < 6) || (strlen($username) > 30) ) // field length in mysql
{
echo "Error - Username must be 6-30 characters long";
}

Nope, I still just get 'Error - You missed something out, press back and try againError - There was a database error when attempting to save your information. Please try again' No matter what

go easy on the brackets man! I missed out all the length stuff, sorry :/

As for your error, i dunno. I'll let you know if I find anything.

OMG I DID IT AGAIN! LEFT MYSELF LOGGED IN.

- Edited By azz0r On Sat 31st, May 2003 @ 3:33:03pm

<?

if (!$username || !$password || !$email || $password!=$password2)
{echo "Error - You missed something out, press back and try again";}



else if (!eregi("^([a-z0-9]+)([._-]([a-z0-9]+))*[@]([a-z0-9]+)([._-]([a-z0-9]+))*[.]([a-z0-9]){2}([a-z0-9])?$", $email))
{echo "Error - Please enter a valid email address i.e. me@mydomain.com";}



else if (mysql_fetch_row(mysql_query("SELECT username FROM unz_users WHERE username = '$username'" )))
{echo "Error - Username already exists";}



else if (mysql_fetch_row(mysql_query("SELECT email FROM unz_users WHERE email = '$email'")))
{echo "Error - Email already exists";}



else if (strlen($username) < 6 )
{echo "Error - Username must be 6+ characters long";}



else if(!ereg("^[[:alpha:]]{4,6}$", $username))
{echo "Error - Weird characters in username; are you trying to harm me?";}



else if (mysql_query("INSERT into unz_users (uid, username, password, email, status, regdate, ip, host) VALUE ('', '$username', '$password',  '$email', 'member', '$regdate', '$ip', '$host')"))
{echo "Success - You are now a registered member of wuggawoo.co.uk";
setcookie("username", "$username", time()+60*60*24*30, '/', '.wuggawoo.co.uk', 0);
setcookie("password", "$password", time()+60*60*24*30, '/', '.wuggawoo.co.uk', 0);}

else

{echo "Error - There was a database error when attempting to save your information.  Please try again.";}

?>

If you put the right details in it still says error, cant figure out whyyyyy

- Edited By azz0r On Sat 31st, May 2003 @ 4:53:50pm

you're STILL logged in?

I was yes, I didnt upload the signup.php page that checks to see if the cookie username is null

Anyway, it still echos Error - There was a database error when attempting to save your information. Please try again at the end of every error and never does success.

your query.

mysql_query("INSERT into unz_users (uid, username, password, email, status, regdate, ip, host) VALUE ('', '$username', '$password', '$email', 'member', '$regdate', '$ip', '$host')")

should be

mysql_query("INSERT into unz_users (uid, username, password, email, status, regdate, ip, host) VALUES ('', '$username', '$password', '$email', 'member', '$regdate', '$ip', '$host')")

notice the VALUES not VALUE

Ill try it to see if it fixes it, but its not echoing sucess - bla bla...

um... um... is anything being added into your database at all? If not then you've got a duff query.