Comments - UndeadStar

That's gonna be painful for GPTP if really the base address is changed.And updating Starcraft to test the new version would mean giving up on support of already built mods for 1.16.1 for those that stick on it.
Headache.

I see a lake/swamp with moss floating at the surface lol

How exactly did you get this memory leak?
I tried to reproduce it, but I tried several maps, including campaign, and could not see any big change.

Is it a matter of choice of map, duration of playing a map, number of maps tested, testing over a longer time (hours?)?
Or could it be it only happen when an unit use it (I was too lazy to make a .dat edit to make an unit use the extended sight range, maybe that's the problem?)
Any clue would be useful.

I want to make my own fix, but if I can't observe the leak, I can't tell if it's fixed.

By the way, setMaxSightRange() call a game function using the map width as a parameter, so maybe successively playing maps with different widths with your fix may produce unexpected results, or even crashes?

Thanks for the report.

Current issue: Overloard got his shield data over his supply info.

While waiting for the download to finish, one thing to say:

Terran\MARINE\TMaSti01.WAV

^^

Would those engine breaks be possible to reproduce with GPTP hook tools (memorypatch and/or jumppatch), or do they require changes beyond that ?